banshee and NET_2_0

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

banshee and NET_2_0

Bertrand Lorentz
Administrator
Hi,

While looking into http://bugzilla.gnome.org/show_bug.cgi?id=533099 I
noticed the following thing :

In two files in trunk there are some lines of code in "#if NET_2_0"
blocks. I'm using mono 1.2.6, and I think it has all the .NET 2.0
features (generics, etc.), so I expected those lines to be compiled.

It turns out that it's not the case (the #else blocks are compiled). Now
I'm all confused and I'd like to be un-confused...

So, is this the expected behaviour ?
If not, is there something wrong on my system (gentoo), or is there
something missing in the banshee build stuff ?

Cheers,

--
Bertrand Lorentz <[hidden email]>
> http://flickr.com/photos/bl8/ <

_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: banshee and NET_2_0

Sandy Armstrong
On 5/16/08, Bertrand Lorentz <[hidden email]> wrote:

> Hi,
>
>  While looking into http://bugzilla.gnome.org/show_bug.cgi?id=533099 I
>  noticed the following thing :
>
>  In two files in trunk there are some lines of code in "#if NET_2_0"
>  blocks. I'm using mono 1.2.6, and I think it has all the .NET 2.0
>  features (generics, etc.), so I expected those lines to be compiled.
>
>  It turns out that it's not the case (the #else blocks are compiled). Now
>  I'm all confused and I'd like to be un-confused...
>
>  So, is this the expected behaviour ?
>  If not, is there something wrong on my system (gentoo), or is there
>  something missing in the banshee build stuff ?

I'm noticing the same thing with Mono 1.9.1 on openSUSE, so it's not
something wrong on your system.  My guess is that the compiler used to
define NET_2_0 under certain circumstances, and no longer does.
Either that or something is missing from Banshee's build scripts, as
you say.

Sandy
_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list
Reply | Threaded
Open this post in threaded view
|

Re: banshee and NET_2_0

Aaron Bockover
In reply to this post by Bertrand Lorentz
The NET_* defines are internal to the class libraries in Mono itself. I wrote RangeCollection initially for Banshee to solve selection management efficiently for our ListView, but then realized Mono's Windows Forms could greatly benefit from the code as well in all the cases where they have to deal with selections.

The problem was that all of the winforms code was .NET 1.1, so I needed to provide two versions that differed slightly. Anyway, apparently we've actually been using the .NET 1.1 version of RangeCollection in Banshee (which has the silly resize bug Bertrand found), since NET_2_0 was never defined in (or maybe was removed from) our build system.

So, I'll define NET_2_0 and apply the patch on the bug.

Thanks Bertrand!

--Aaron

>>> "Sandy Armstrong" <[hidden email]> 05/16/08 5:09 PM >>>
On 5/16/08, Bertrand Lorentz <[hidden email]> wrote:

> Hi,
>
>  While looking into http://bugzilla.gnome.org/show_bug.cgi?id=533099 I
>  noticed the following thing :
>
>  In two files in trunk there are some lines of code in "#if NET_2_0"
>  blocks. I'm using mono 1.2.6, and I think it has all the .NET 2.0
>  features (generics, etc.), so I expected those lines to be compiled.
>
>  It turns out that it's not the case (the #else blocks are compiled). Now
>  I'm all confused and I'd like to be un-confused...
>
>  So, is this the expected behaviour ?
>  If not, is there something wrong on my system (gentoo), or is there
>  something missing in the banshee build stuff ?

I'm noticing the same thing with Mono 1.9.1 on openSUSE, so it's not
something wrong on your system.  My guess is that the compiler used to
define NET_2_0 under certain circumstances, and no longer does.
Either that or something is missing from Banshee's build scripts, as
you say.

Sandy
_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list

_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list
Reply | Threaded
Open this post in threaded view
|

Re: banshee and NET_2_0

Bertrand Lorentz
Administrator
Well, a bug has been fixed, the proper code is now compiled, and I've
been un-confused ! Excellent !

While working on the regression test for the resize bug, I noticed that
several tests are failing for me. I see that in the meantime you've
already fixed one.

The ones that are now failing are :
1) StringUtilTests.TestDoubleToTenthsPrecision
2) QueryTests.TestQueryValueSql
3) QueryTests.TestQueryParsing

Is it worth looking into ?

--
Bertrand Lorentz <[hidden email]>
> http://flickr.com/photos/bl8/ <


On Sat, 2008-05-17 at 01:01 -0600, Aaron Bockover wrote:

> The NET_* defines are internal to the class libraries in Mono itself. I wrote RangeCollection initially for Banshee to solve selection management efficiently for our ListView, but then realized Mono's Windows Forms could greatly benefit from the code as well in all the cases where they have to deal with selections.
>
> The problem was that all of the winforms code was .NET 1.1, so I needed to provide two versions that differed slightly. Anyway, apparently we've actually been using the .NET 1.1 version of RangeCollection in Banshee (which has the silly resize bug Bertrand found), since NET_2_0 was never defined in (or maybe was removed from) our build system.
>
> So, I'll define NET_2_0 and apply the patch on the bug.
>
> Thanks Bertrand!
>
> --Aaron
>
> >>> "Sandy Armstrong" <[hidden email]> 05/16/08 5:09 PM >>>
> On 5/16/08, Bertrand Lorentz <[hidden email]> wrote:
> > Hi,
> >
> >  While looking into http://bugzilla.gnome.org/show_bug.cgi?id=533099 I
> >  noticed the following thing :
> >
> >  In two files in trunk there are some lines of code in "#if NET_2_0"
> >  blocks. I'm using mono 1.2.6, and I think it has all the .NET 2.0
> >  features (generics, etc.), so I expected those lines to be compiled.
> >
> >  It turns out that it's not the case (the #else blocks are compiled). Now
> >  I'm all confused and I'd like to be un-confused...
> >
> >  So, is this the expected behaviour ?
> >  If not, is there something wrong on my system (gentoo), or is there
> >  something missing in the banshee build stuff ?
>
> I'm noticing the same thing with Mono 1.9.1 on openSUSE, so it's not
> something wrong on your system.  My guess is that the compiler used to
> define NET_2_0 under certain circumstances, and no longer does.
> Either that or something is missing from Banshee's build scripts, as
> you say.
>
> Sandy


_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: banshee and NET_2_0

Bertrand Lorentz
Administrator
On Sat, 2008-05-17 at 15:29 +0200, Bertrand Lorentz wrote:

> Well, a bug has been fixed, the proper code is now compiled, and I've
> been un-confused ! Excellent !
>
> While working on the regression test for the resize bug, I noticed that
> several tests are failing for me. I see that in the meantime you've
> already fixed one.
>
> The ones that are now failing are :
> 1) StringUtilTests.TestDoubleToTenthsPrecision
> 2) QueryTests.TestQueryValueSql
> 3) QueryTests.TestQueryParsing
It turns out that the first two failures happen because of locale and
timezone issues.

See http://bugzilla.gnome.org/show_bug.cgi?id=533569 for a one line fix,
or move to Chicago and learn italian ;)

Cheers,

--
Bertrand Lorentz <[hidden email]>
> http://flickr.com/photos/bl8/ <

_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: banshee and NET_2_0

Gabriel Burt
2008/5/17 Bertrand Lorentz <[hidden email]>:

> On Sat, 2008-05-17 at 15:29 +0200, Bertrand Lorentz wrote:
>> Well, a bug has been fixed, the proper code is now compiled, and I've
>> been un-confused ! Excellent !
>>
>> While working on the regression test for the resize bug, I noticed that
>> several tests are failing for me. I see that in the meantime you've
>> already fixed one.
>>
>> The ones that are now failing are :
>> 1) StringUtilTests.TestDoubleToTenthsPrecision
>> 2) QueryTests.TestQueryValueSql
>> 3) QueryTests.TestQueryParsing
>
> It turns out that the first two failures happen because of locale and
> timezone issues.
>
> See http://bugzilla.gnome.org/show_bug.cgi?id=533569 for a one line fix,
> or move to Chicago and learn italian ;)

Haha.  :)  Thanks for the patch.  The TestQueryParsing bug is a known
issue with our parser.

Gabriel
_______________________________________________
Banshee-list mailing list
[hidden email]
http://mail.gnome.org/mailman/listinfo/banshee-list